-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/database/sql: Disable DBStats if statsd client initialization fails #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddr, and add tracer test to confirm the globalconfig inerhits the tracer's dogstatsd address even when UDS
github-actions
bot
added
the
apm:ecosystem
contrib/* related feature requests or bugs
label
May 2, 2024
…h a nil statsd client
mtoffl01
commented
May 2, 2024
felixge
approved these changes
May 3, 2024
darccio
approved these changes
May 3, 2024
rarguelloF
approved these changes
May 8, 2024
darccio
approved these changes
May 8, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DBStats is disabled — and no metric submission is attempted from the database/sql contrib — when the contrib fails to create a statsd client. This can happen if, for example, the DogStatsD address granted to the tracer is an inaccessible unix domain socket.
Motivation
The contrib/database/sql was attempting metric submission if the DBStats feature was enabled, even if the statsd client initialization failed. This was causing a nil pointer exception when the
nil
statsd client was called upon to submit metrics (e.g,statsd.Gauge(...)
wherestatsd
is nil)Reviewer's Checklist
Unsure? Have a question? Request a review!